You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the documentation for the new RSS content feature added in this PR to the Astro repo. I wrote some basic documentation detailing how to use the new content property on the RSSObject, as well as added some warnings that the feature only works for markdown (not MDX) and that the HTML passed to the content property must be sanitized/escaped.
@bholmesdev please let me know if you have any feedback on the docs that I've added here! 😃
OK, I think I'm happy with this! @delucis / @smithbm2316 - if anyone has any objections with my tiny changes, speak up! Otherwise, I'll consider this good to merge when the feature does! 🚀
OK, I think I'm happy with this! @delucis / @smithbm2316 - if anyone has any objections with my tiny changes, speak up! Otherwise, I'll consider this good to merge when the feature does! rocket
Looks great! Thanks again for your revisions and review 😄
Thanks @bholmesdev, but I think we need to wait for the next release? (not just merge?) The docs go live instantly, but we've been burned before by not waiting for the feature to go live in a release! 😅
Thanks again @smithbm2316! Now this is released in [email protected] we can merge this. I’m going to add a <Since v="1.6.14" /> badge to this section so we know what the minimum required Astro version is to do this.
merge-on-releaseDon't merge this before the feature is released! (MQ=approved but WAIT for feature release!)minor-releaseFor the next minor release; in the milestone, "merge queue" when approved by Sarah!
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sarah11918
added
the
merge-on-release
What kind of changes does this PR include?
Description
Implements the documentation for the new RSS
contentfeature added in this PR to the Astro repo. I wrote some basic documentation detailing how to use the newcontentproperty on theRSSObject, as well as added some warnings that the feature only works for markdown (not MDX) and that the HTML passed to thecontentproperty must be sanitized/escaped.@bholmesdev please let me know if you have any feedback on the docs that I've added here! 😃